History | Log In     View a printable version of the current page. Get help!  
Issue Details [XML]

Key: SES-717
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Arjohn Kampman
Reporter: James Leigh
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sesame

QueryModelNodeBase.toString() is called on every evaluation

Created: 20/Jul/10 10:09 PM   Updated: 20/Jul/10 10:18 PM
Component/s: Native Sail
Affects Version/s: 2.3.2
Fix Version/s: 2.3.3


 Description   
Lines like this one below will always evaluate toString() regardless of the logging level set in the logger.

replace: logger.trace("Incoming query model:\n{}", tupleExpr.toString());
with: logger.trace("Incoming query model:\n{}", tupleExpr);

Let slf4j call the toString() method on the parameters *iff* the message is to be logged. This message was found in NativeStoreConnection#evaluateInternal, but there might be more.

 All   Comments   Change History      Sort Order:
Comment by Arjohn Kampman [20/Jul/10 10:18 PM]
Fixed in both the native store and the memory store.