History | Log In     View a printable version of the current page. Get help!  
Issue Details [XML]

Key: SES-115
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Jeen Broekstra
Reporter: Philip Shaw
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Sesame

Wildcard import statements do not compile with GCJ

Created: 07/Jan/05 01:01 PM   Updated: 13/May/05 10:44 PM
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2-RC1

Environment: Any where GCJ is available, including GNU/Linux and Cygwin


 Description   
Many Sesame classes use wildcard import statements for org.openrdf packages that will not compile because of a bug in the GCJ compiler, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10894.

I am planning to amend the Sesame source to make these statements explicit for a project I am working on. I would like to contribute these enhancements to the Sesame project. Please let me know if you would be interested in this contribution and the best approach for me to do so.

Best regards,

Phil

 All   Comments   Change History      Sort Order:
Comment by Jeen Broekstra [07/Feb/05 11:18 AM]
We are reluctant to do this for a number of reasons, the most important of which is that making all import statements explicit severely clutters up the source code.

Thank you for the offer nonetheless. What I would recommend is that you pressure the GCJ people into fixing this issue (which IMO _really_ limits their usefulness as a serious java compiler), or switch to a different compiler (Sun or IBM both have decent compilers).

Comment by Philip Shaw [08/Feb/05 11:25 AM]
Jeen,

I accept your decision, it's your project after all, but I am a little disappointed. GCJ clearly is at fault here, but I would say it is bad programming style to use wildcard import statements. Explicit imports would only add 4 or 5 lines to the source in most cases, for the primary model interfaces.

I am working on another GPL project that incorporates Sesame and I am trying to avoid the so-called "Java trap" by building in parallel with Sun and GCJ, see below. Sesame certainly does compile successfully with the Sun compiler, but it would really help if Sesame was "clean" coded upstream so my project can keep up to date with the Sesame code base.

No hard feelings, just one last appeal to you.

Best regards,

Phil

http://www.gnu.org/philosophy/java-trap.html

Comment by Jeen Broekstra [16/Feb/05 03:46 PM]
I've started a discussion about this on the forum, at http://www.openrdf.org/forum/mvnforum/viewthread?thread=472 , to solicit the opinions of other developers.

A possible compromise for your project could be to use a tool like Eclipse to make the imports explicit every time you update your local source copy (simply select the project and press Crtl+Shift+o).

Comment by Jeen Broekstra [15/Mar/05 03:16 PM]
After further discussion (see the forum link), we've decided to reformat the code base. The current CVS trunk now only uses explicit imports.