[#SES-1018] Leading comment in SPARQL query causes HTTPQueryEvaluationException

Issue Details [XML]

Key:	SES-1018
Type:	Bug
Status:	Resolved
Resolution:	Fixed
Priority:	Major
Assignee:	Jeen Broekstra
Reporter:	Barry Bishop
Votes:	0
Watchers:	0

Operations

If you were logged in you would be able to see more operations.

Sesame

Leading comment in SPARQL query causes HTTPQueryEvaluationException

Created: 30/May/12 09:44 PM Updated: 30/May/12 10:28 PM

Component/s:

HTTP Server

Affects Version/s:

2.6.5

Fix Version/s:

2.6.6

Environment:

Sesame workbench + server. Any repository type.

Description

When executed from the workbench, this query evaluates correctly:

SELECT * { ?s ?p ?v . }
# My comment here
LIMIT 10

but this query:

# My comment here
SELECT * { ?s ?p ?v . }
LIMIT 10

gives the following exception:

javax.servlet.ServletException: org.openrdf.repository.http.HTTPQueryEvaluationException: Server responded with an unsupported file format: application/sparql-results+xml
org.openrdf.workbench.base.TransformationServlet.service(TransformationServlet.java:80)
org.openrdf.workbench.base.BaseServlet.service(BaseServlet.java:40)
org.openrdf.workbench.proxy.ProxyRepositoryServlet.service(ProxyRepositoryServlet.java:93)
org.openrdf.workbench.proxy.WorkbenchServlet.service(WorkbenchServlet.java:131)
org.openrdf.workbench.proxy.WorkbenchServlet.service(WorkbenchServlet.java:90)
org.openrdf.workbench.proxy.WorkbenchGateway.service(WorkbenchGateway.java:109)
org.openrdf.workbench.base.BaseServlet.service(BaseServlet.java:40)
org.openrdf.workbench.proxy.CookieCacheControlFilter.doFilter(CookieCacheControlFilter.java:52)

root cause

org.openrdf.repository.http.HTTPQueryEvaluationException: Server responded with an unsupported file format: application/sparql-results+xml
org.openrdf.repository.http.HTTPGraphQuery.evaluate(HTTPGraphQuery.java:48)
org.openrdf.workbench.commands.QueryServlet.evaluateGraphQuery(QueryServlet.java:231)
org.openrdf.workbench.commands.QueryServlet.service(QueryServlet.java:152)
org.openrdf.workbench.commands.QueryServlet.service(QueryServlet.java:99)
org.openrdf.workbench.commands.QueryServlet.service(QueryServlet.java:72)
org.openrdf.workbench.base.TransformationServlet.service(TransformationServlet.java:73)
org.openrdf.workbench.base.BaseServlet.service(BaseServlet.java:40)
org.openrdf.workbench.proxy.ProxyRepositoryServlet.service(ProxyRepositoryServlet.java:93)
org.openrdf.workbench.proxy.WorkbenchServlet.service(WorkbenchServlet.java:131)
org.openrdf.workbench.proxy.WorkbenchServlet.service(WorkbenchServlet.java:90)
org.openrdf.workbench.proxy.WorkbenchGateway.service(WorkbenchGateway.java:109)
org.openrdf.workbench.base.BaseServlet.service(BaseServlet.java:40)
org.openrdf.workbench.proxy.CookieCacheControlFilter.doFilter(CookieCacheControlFilter.java:52)

root cause

org.openrdf.repository.RepositoryException: Server responded with an unsupported file format: application/sparql-results+xml
org.openrdf.http.client.HTTPClient.getRDF(HTTPClient.java:1177)
org.openrdf.http.client.HTTPClient.sendGraphQuery(HTTPClient.java:522)
org.openrdf.http.client.HTTPClient.sendGraphQuery(HTTPClient.java:497)
org.openrdf.repository.http.HTTPGraphQuery.evaluate(HTTPGraphQuery.java:41)
org.openrdf.workbench.commands.QueryServlet.evaluateGraphQuery(QueryServlet.java:231)
org.openrdf.workbench.commands.QueryServlet.service(QueryServlet.java:152)
org.openrdf.workbench.commands.QueryServlet.service(QueryServlet.java:99)
org.openrdf.workbench.commands.QueryServlet.service(QueryServlet.java:72)
org.openrdf.workbench.base.TransformationServlet.service(TransformationServlet.java:73)
org.openrdf.workbench.base.BaseServlet.service(BaseServlet.java:40)
org.openrdf.workbench.proxy.ProxyRepositoryServlet.service(ProxyRepositoryServlet.java:93)
org.openrdf.workbench.proxy.WorkbenchServlet.service(WorkbenchServlet.java:131)
org.openrdf.workbench.proxy.WorkbenchServlet.service(WorkbenchServlet.java:90)
org.openrdf.workbench.proxy.WorkbenchGateway.service(WorkbenchGateway.java:109)
org.openrdf.workbench.base.BaseServlet.service(BaseServlet.java:40)
org.openrdf.workbench.proxy.CookieCacheControlFilter.doFilter(CookieCacheControlFilter.java:52)

All

Comments

Change History

Sort Order:

[ Permlink ]

Comment by Jeen Broekstra [30/May/12 10:14 PM]

cause is a bug in QueryParserUtil, which determines whether the input string is a query or update by stripping the prolog and looking at the first clause (SELECT/CONSTRUCT/INSERT/etc.). The stripping method does not take comments into account.

[ Permlink ]

Comment by Jeen Broekstra [30/May/12 10:28 PM]

fixed, just in time for 2.6.6 :)